Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use wasm_bindgen_futures::spawn_local instead of BevyIoTaskPool in wasm #352

Merged
merged 4 commits into from
May 14, 2024
Merged

Use wasm_bindgen_futures::spawn_local instead of BevyIoTaskPool in wasm #352

merged 4 commits into from
May 14, 2024

Conversation

cBournhonesque
Copy link
Owner

@cBournhonesque cBournhonesque commented May 14, 2024 •
edited
Loading

Try to fix #144

  • fix some other bugs related to the io refactor (the goal of the refactor was that the io tasks get stopped if we are disconnected in netcode (for example if a client requests disconnect). Conversely, if the io task gets disconnected, we want to update the state in netcode to disconnected as well)

@cBournhonesque cBournhonesque added C-Bug Something isn't working A-Transport Related to the transport layer labels May 14, 2024
@cBournhonesque cBournhonesque mentioned this pull request May 14, 2024
Closed
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 66.61%. Comparing base (7da67eb) to head (30fe00a).

Files Patch % Lines
lightyear/src/transport/error.rs 0.00% 2 Missing ⚠️
lightyear/src/connection/netcode/server.rs 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #352      +/-   ##
==========================================
- Coverage   66.62%   66.61%   -0.02%     
==========================================
  Files         155      155              
  Lines        9787     9789       +2     
==========================================
  Hits         6521     6521              
- Misses       3266     3268       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cBournhonesque cBournhonesque merged commit 1475df6 into main May 14, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-Transport Related to the transport layer C-Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WASM examples broken if the user switches tabs
2 participants
@cBournhonesque @codecov-commenter